KAFKA-18071: Avoid event to refresh regex if no pattern subscription #17917
+36
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dajac
approved these changes
Nov 22, 2024
| @@ -320,11 +320,12 @@ private void process(final TopicPatternSubscriptionChangeEvent event) { | |||
| * This will make the consumer send the updated subscription on the next poll. | |||
| */ | |||
| private void process(final UpdatePatternSubscriptionEvent event) { | |||
| if (!subscriptions.hasPatternSubscription()) { | |||
There was a problem hiding this comment.
Is this test really necessary? This event is only sent if the application thread knows there's a pattern subscription.
There was a problem hiding this comment.
truly it's not needed with the current usage of this event from the app thread. I just left it for extra protection in this thread really (ok to remove it if we prefer)
There was a problem hiding this comment.
Just checking my understanding. It looks like the remains of an earlier thought :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to check if the consumer has a pattern subscription before generating a background event to refresh the regex against metadata.
This happens as part of the poll loop, so avoiding the unnecessary event and block waiting for it (the check was performed in the background before this PR).
Checking hasSubscriptionPattern in the app thread should be safe because the subscription type only changes with api calls to subscribe/assign/unsubscribe, that all block until the subscription state is updated.